Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check language server symbol renaming support before prompting #6257

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Check language server symbol renaming support before prompting #6257

merged 3 commits into from
Mar 13, 2023

Conversation

misiasty3
Copy link
Contributor

Tried my best to fix #6249
Tell me if there is something to change 😄

@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-language-server Area: Language server client S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 10, 2023
@the-mikedavis the-mikedavis self-requested a review March 10, 2023 23:08
the-mikedavis
the-mikedavis reviewed Mar 12, 2023
View reviewed changes
helix-lsp/src/client.rs Show resolved Hide resolved
helix-term/src/commands/lsp.rs Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis changed the title Check if lsp supports symbol renaming before prompting the user Check language server symbol renaming support before prompting Mar 13, 2023
@the-mikedavis the-mikedavis merged commit db8e9f5 into helix-editor:master Mar 13, 2023
@the-mikedavis
Copy link
Member

Thanks!

@misiasty3 misiasty3 deleted the check-sr-support branch March 13, 2023 16:14
sagnibak pushed a commit to sagnibak/helix that referenced this pull request Mar 21, 2023
@misiasty3 @poliorcetics
Check language server symbol renaming support before prompting (helix…
95eeb94 
…-editor#6257)

Co-authored-by: Poliorcetics <[email protected]>
@Philipp-M Philipp-M mentioned this pull request Mar 27, 2023
Merged
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@misiasty3 @poliorcetics @wes-adams
Check language server symbol renaming support before prompting (helix…
6a02475 
…-editor#6257)

Co-authored-by: Poliorcetics <[email protected]>
@the-mikedavis the-mikedavis mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poliorcetics poliorcetics poliorcetics left review comments

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-language-server Area: Language server client C-enhancement Category: Improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check language server rename support before showing rename-to prompt
3 participants
@misiasty3 @the-mikedavis @poliorcetics